Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvments for cti-kb project #1

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mathieudupoux
Copy link

@mathieudupoux mathieudupoux commented Jun 27, 2024

I'm using your work for professional purposes but I was faced to several issues and features needs. Therefore, I've taken the liberty to fork your project to fix issues and add some improvements. It would be a shame not to take advantage of this to benefit the initial project.

Here are my improvements :

  1. Reformat the script file with default Ruff linting rules
  2. Remove useless imports
  3. Fix wrong MITRE database (originally link to Github URL page and not raw JSON file
  4. Add .env file to configure script instead of editing it
  5. Add external_id (ex: T1xxx for Techniques id) and depreciated property on nodes if available

Feel free to ask me for more information or any suggestions you would have before merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant